Add support for externally provided 'lifecycle-mapping-metadata.xml' file #3005
Conversation
|
@testforstephen as the original filer for the issue that this intends to fix, let us know if this meets those needs. |
| IEclipsePreferences prefs = InstanceScope.INSTANCE.getNode(IMavenConstants.PLUGIN_ID); | ||
| String oldMavenLifecycleMappings = prefs.get(MavenPreferenceConstants.P_WORKSPACE_MAPPINGS_LOCATION, null); |
There was a problem hiding this comment.
Why not to use its getter api getMavenConfiguration().getWorkspaceLifecycleMappingMetadataFile() to retrieve the current lifecycle mapping config? I see you have used its setter api to update the lifecycle mapping config in subsequent operation.
There was a problem hiding this comment.
We don't want to update the projects if the maven lifecycle mapping is not set.
m2e lifecycle mapping is <m2e_core_location>/lifecycle-mapping-metadata.xml by default, VS Code lifecycle mapping is null by default
See https://github.com/eclipse-m2e/m2e-core/blob/db42af86c7976a6131daf4cda1a10857e497bf92/org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/preferences/MavenConfigurationImpl.java#L266
There was a problem hiding this comment.
This touches too much the internal implementation of m2e, which is not a good practice from a maintenance standpoint.
To identify if users have changed the lifecycle mapping in jdt.ls, I prefer to store the lifecycle mapping setting within jdt.ls metadata cache. We can then use jdt.ls preference cache to identify any diff. If any modification is detected, then call m2e API to apply it.
There was a problem hiding this comment.
trying...
I have updated the PR.
| if (!Objects.equals(newMavenLifecycleMappings, oldMavenLifecycleMappings)) { | ||
| try { | ||
| getMavenConfiguration().setWorkspaceLifecycleMappingMetadataFile(newMavenLifecycleMappings); | ||
| LifecycleMappingFactory.getWorkspaceMetadata(true); |
There was a problem hiding this comment.
what does this line do and why is it needed?
There was a problem hiding this comment.
It reloads the lifecycle mapping. I have copied it from https://github.com/eclipse-m2e/m2e-core/blob/db42af86c7976a6131daf4cda1a10857e497bf92/org.eclipse.m2e.core.ui/src/org/eclipse/m2e/core/ui/internal/preferences/LifecycleMappingPreferencePage.java#L93
There was a problem hiding this comment.
Then you should consider adding a comment to clarify the purpose of this code. Without it, other maintainers may find it hard to understand what it does from the method call alone.
…file Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
Fixes redhat-developer/vscode-java#3393
Requires redhat-developer/vscode-java#3440